functional

gen_pc_sidecar.php

@@ -16,12 +16,40 @@
 $bootstrap_settings['freepbx_auth'] = false;
 require_once('/etc/freepbx.conf');
 
-$provision_dir = '/tftpboot';                                // <-- adjust if needed
-$out_file      = $provision_dir . '/482567bcdeff-features.cfg';
+function main(): void {
+
+  $provision_dir = '/tftpboot';
+  $file = $provision_dir . '/482567bcdeff-features.cfg';
+  $argv = $_SERVER['argv'] ?? [];
   $do_notify = in_array('--notify', $argv, true);
 
+  $pbdb = pull_db();
+
+  array_unshift($pbdb, [
+      'name'      => 'Night time',
+      'extension' => '*271',
+  ]);
+
+  $blank = ['name' => ' ', 'extension' => ' '];
+  array_splice($rows, 1, 0, array_fill(0, 5, $blank));
+
+  $xml = pull_xml_file($file);
+  
+  $attendant = remove_attendants($xml);
+
+  write_attendants($attendant, $pbdb);
+
+  write_to_file($provision_dir, $file, $xml);
+
+  if ($do_notify) {
+    notify($pbdb);
+  }
+}
+
+
+function pull_db(): array {
   $db = FreePBX::Database();
-$rows = [];
+  $pbdb = [];
 
   /** Try Core 'users' table first (name + extension) */
   try {
@@ -32,13 +60,13 @@ try {
           ORDER BY CAST(extension AS UNSIGNED)
       ");
       $stmt->execute();
-    $rows = $stmt->fetchAll(PDO::FETCH_ASSOC);
+      $pbdb = $stmt->fetchAll(PDO::FETCH_ASSOC);
   } catch (Exception $e) {
       // ignore, fall back below
   }
 
   /** Fall back to PJSIP ps_endpoints (id is ext; parse callerid "Name <1001>") */
-if (!$rows) {
+  if (!$pbdb) {
       $stmt = $db->prepare("
           SELECT id AS extension, callerid
           FROM ps_endpoints
@@ -63,23 +91,23 @@ if (!$rows) {
                   }
               }
           }
-        $rows[] = ['name' => $name, 'extension' => $ext];
+          $pbdb[] = ['name' => $name, 'extension' => $ext];
       }
   }
 
-if (!$rows) {
-    fwrite(STDERR, "No extensions found (users/ps_endpoints returned no rows).\n");
+  if (!$pbdb) {
+      fwrite(STDERR, "No extensions found (users/ps_endpoints returned no pbdb).\n");
       exit(1);
   }
 
-array_unshift($rows, [
-    'name'      => 'Night time',
-    'extension' => '*271',
-]);
+  return $pbdb;
+}
 
-$xmlString = file_get_contents($out_file);
+
+function pull_xml_file($file): DOMDocument {
+  $xmlString = file_get_contents($file);
   if ($xmlString === false) {
-    throw new RuntimeException("Unable to read file: {$out_file}");
+      throw new RuntimeException("Unable to read file: {$file}");
   }
 
   // Strip UTF-8 BOM and leading whitespace
@@ -107,6 +135,10 @@ if (!$xml->loadXML($xmlString)) {
       throw new RuntimeException($msg);
   }
 
+  return $xml;
+}
+
+function remove_attendants($xml): DOMElement {
   $xpath = new DOMXPath($xml);
   $attendantNodes = $xpath->query('/polycomConfig/attendant');
   if ($attendantNodes->length === 0) {
@@ -126,28 +158,30 @@ foreach ($toRemove as $name) {
       $attendant->removeAttribute($name);
   }
 
+  return $attendant;
+}
+
+function write_attendants($attendant, $pbdb): void {
   $index =  1;
-foreach ($rows as $r) {
+  foreach ($pbdb as $r) {
       $label = trim((string)($r['name'] ?? ''));
       $address  = trim((string)($r['extension'] ?? ''));
       $type = trim((string)("normal"));
 
-    if ($address === '' && $index > 6) continue;
-
       $attendant->setAttribute("attendant.resourceList.{$index}.address", $address);
       $attendant->setAttribute("attendant.resourceList.{$index}.label",   $label);
       $attendant->setAttribute("attendant.resourceList.{$index}.type",    $type);
 
       $index++;
   }
+}
 
-/** Ensure provision dir exists */
+function write_to_file($provision_dir, $out_file, $xml): void {
   if (!is_dir($provision_dir)) {
       fwrite(STDERR, "Provisioning directory not found: $provision_dir\n");
       exit(2);
   }
 
-/** Atomic write */
   $tmpfile = $out_file . '.tmp';
   if ($xml->save($tmpfile) === false) {
       fwrite(STDERR, "Failed to write temporary file $tmpfile\n");
@@ -160,12 +194,13 @@ if (!@rename($tmpfile, $out_file)) {
   }
 
   echo "Wrote $out_file \n";
+}
 
+function notify($pbdb): void {
     /** Optional: push check-sync to re-download directory without reboot */
-if ($do_notify) {
     // Use the extension list we already built
     $notified = 0;
-    foreach ($rows as $r) {
+    foreach ($pbdb as $r) {
         $ext = trim((string)$r['extension']);
         if ($ext === '') continue;
         // In FreePBX, PJSIP endpoint id is typically the extension number
@@ -175,3 +210,5 @@ if ($do_notify) {
     }
     echo "Sent check-sync to $notified endpoints\n";
 }
+
+main();