Remove ?token= deletion-token path (#143)
CI / test (pull_request) Successful in 35s
CI / docker (pull_request) Skipped

The deletion token was accepted via the ?token= query parameter on both
DELETE /api/pastes/{id} and /redeem, and round-tripped through the paste
URL after creation. URL-carried bearer secrets leak into reverse-proxy
access logs and browser history.

- API: deletion tokens are now accepted only via the Authorization header
  (Bearer/Token/bare); query params are ignored on both endpoints
- Web create flow: token moves to the browser via a short-lived tok_<id>
  HttpOnly cookie instead of the redirect URL; the paste view reads it
  from the cookie, never from ?token=
- Web view: the delete button calls redeem() which takes the token from
  sessionStorage and sends it as an Authorization header
- Tests: correct token in query must be rejected (403/400); header path
  still deletes/redeems; extraction unit cases updated

Fixes #143
This commit is contained in:
fen
2026-09-10 08:24:05 -05:00
parent 33ccfd373a
commit 27763cd1ba
7 changed files with 81 additions and 29 deletions
+4 -2
View File
@@ -20,10 +20,12 @@ func (a *apiServer) burnViewerWindow() int {
}
// handleRedeemDeletion lets a holder of the deletion token hard-delete immediately.
// DELETE /api/pastes/{id}/redeem?token=...
// DELETE /api/pastes/{id}/redeem with the token in the Authorization header
// (#143: the ?token= query path was removed so the secret stays out of
// access logs and browser history).
func (a *apiServer) handleRedeemDeletion(w http.ResponseWriter, r *http.Request) {
id := chi.URLParam(r, "id")
token := r.URL.Query().Get("token")
token := deletionAuthorization(r)
if token == "" {
writeErr(w, 400, "token required")
return