Merge pull request 'Fix #184: file upload replaces the main editing area on /new' (#189) from fix-184 into dev
CI / test (push) Successful in 43s
CI / docker (push) Successful in 44s

This commit was merged in pull request #189.
This commit is contained in:
fen
2026-09-10 16:55:32 +00:00
+7 -5
View File
@@ -280,11 +280,12 @@ async function showFileInEditor(file) {
if (!TEXT_EXTS.has(extOf(file.name))) return; // unknown binary: leave editor alone if (!TEXT_EXTS.has(extOf(file.name))) return; // unknown binary: leave editor alone
try { try {
const text = await file.text(); const text = await file.text();
if (!content.value.trim()) { // #184: the file replaces the main editing area, so the text always
// loads over whatever was in the editor (same rule as images, which
// hide the editor entirely).
content.value = text; content.value = text;
updateGutter(); updateGutter();
guessLang(); guessLang();
}
} catch (e) {} } catch (e) {}
} }
@@ -306,9 +307,10 @@ function setAttachedFile(file) {
attachedFile = file; attachedFile = file;
renderFileChip(); renderFileChip();
setHidden('file-text-note', false); setHidden('file-text-note', false);
// #171: title auto-fill — images take the file name; text files use the // #171/#184: title auto-fill — images take the file name; text files
// language-placeholder convention (e.g. Python.py, fallback Text.txt). // use the language-placeholder convention (e.g. Python.py, fallback
// Only when the title is still blank; never overwrite a typed title. // Text.txt). Only when the title is still blank; never overwrite a
// typed title.
if (!$('title').value.trim()) { if (!$('title').value.trim()) {
if (IMAGE_RE.test(file.type)) { if (IMAGE_RE.test(file.type)) {
$('title').value = file.name; $('title').value = file.name;