Fix #138: add Secure attribute to viewer cookie (vwr) #154

Merged
fen merged 1 commits from fix-138 into dev 2026-09-10 13:43:21 +00:00
Collaborator

Sets Secure on the vwr viewer cookie in viewerCookieMiddleware (the only site that sets vwr; all other set-cookie sites are pw_/tok_ cookies, untouched per issue scope).

All deployments are HTTPS-only behind traefik, so this is defense-in-depth: the cookie will no longer be sent if a user ever hits a plain-HTTP listener. Tradeoff: local dev/tests over plain HTTP will not round-trip the cookie in clients, so the new test (TestViewerCookieAttributes) asserts the Set-Cookie attributes directly rather than relying on cookie round-tripping.

Fixes #138

Sets `Secure` on the vwr viewer cookie in `viewerCookieMiddleware` (the only site that sets vwr; all other set-cookie sites are pw_/tok_ cookies, untouched per issue scope). All deployments are HTTPS-only behind traefik, so this is defense-in-depth: the cookie will no longer be sent if a user ever hits a plain-HTTP listener. Tradeoff: local dev/tests over plain HTTP will not round-trip the cookie in clients, so the new test (`TestViewerCookieAttributes`) asserts the Set-Cookie attributes directly rather than relying on cookie round-tripping. Fixes #138
fen added 1 commit 2026-09-10 13:42:14 +00:00
#138: add Secure attribute to viewer cookie (vwr)
CI / docker (pull_request) Skipped
CI / test (pull_request) Successful in 29s
521b6f8011
fen force-pushed fix-138 from b65dd0a24f to 521b6f8011 2026-09-10 13:42:14 +00:00 Compare
fen merged commit ca77250cce into dev 2026-09-10 13:43:21 +00:00
Sign in to join this conversation.