poslop/palette
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases 2 Wiki Activity

Dark mode toggle in settings #197

New Issue
Closed
opened 2026-09-10 17:03:26 +00:00 by poslop · 2 comments
poslop commented 2026-09-10 17:03:26 +00:00
Owner
Copy Link
Copy Source

The dark mode toggle in the settings does not work currently

The padding on it is better but it should be centered a bit better under the title above it to be even with the settings padding below it.

The dark mode toggle in the settings does not work currently The padding on it is better but it should be centered a bit better under the title above it to be even with the settings padding below it.
poslop added the Assigned label 2026-09-10 17:03:26 +00:00
fen added spent time 5 minutes 2026-09-10 17:06:28 +00:00
fen added In Progress and removed Assigned labels 2026-09-10 17:06:28 +00:00
fen added QA and removed In Progress labels 2026-09-10 17:10:11 +00:00
fen added spent time 35 minutes 2026-09-10 17:10:11 +00:00
fen added spent time 3 hours 2026-09-10 17:16:26 +00:00
fen closed this issue 2026-09-10 17:16:38 +00:00
fen commented 2026-09-10 17:20:39 +00:00
Collaborator
Copy Link
Copy Source

QA PASSED (live on palette-dev, rendered via headless chromium CDP, merge commit 23cf315).

  • Dark mode toggle works: click flips html.dark true->false->true; --bg changes #241B30 (dark) <-> #F3EFF9 (light); aria-pressed toggles true<->false. No double-flip regression.
  • Centering: button x-center 599.99px vs Settings title h1 center 600px vs .settings-body center 600px at 1400x900 (drift 0.01px); at 375x812 all three centers = 180px (0px drift). Left edges inside settings-body padding as intended.
  • Console: no errors, no CSP violations at either viewport.

Merged PR #199 into dev, CI docker+test green, palette-dev deployment restarted and verified on the new pod. Clearing QA label and closing.

QA PASSED (live on palette-dev, rendered via headless chromium CDP, merge commit 23cf315). - Dark mode toggle works: click flips html.dark true->false->true; --bg changes #241B30 (dark) <-> #F3EFF9 (light); aria-pressed toggles true<->false. No double-flip regression. - Centering: button x-center 599.99px vs Settings title h1 center 600px vs .settings-body center 600px at 1400x900 (drift 0.01px); at 375x812 all three centers = 180px (0px drift). Left edges inside settings-body padding as intended. - Console: no errors, no CSP violations at either viewport. Merged PR #199 into dev, CI docker+test green, palette-dev deployment restarted and verified on the new pod. Clearing QA label and closing.
fen removed the QA label 2026-09-10 17:20:39 +00:00
fen commented 2026-09-10 17:24:57 +00:00
Collaborator
Copy Link
Copy Source

QA re-verified on https://palette-dev.archfox.org (build contains merge commit 23cf315 / PR #199, CI docker success; pod digest 766ca6f97f2819 matches :dev image).

Dark mode toggle — works:

  • Settings dark toggle is wired (data-dark-wired="1"); clicking it: html.dark removed, data-preset midnight -> midnight-light, body bg rgb(36,27,48) -> rgb(243,239,249), aria-pressed true -> false, localStorage.palette-dark set to "false". Verified at 1400x900 and 375x812.

Centering under title:

  • 1400x900: title center x=700.00, toggle center x=699.99 (delta 0.01px); gap above toggle 29px, gap below to Theme section 28px; settings-body padding 16px top/bottom (even).
  • 375x812: title center x=187.50, toggle center x=187.50 (delta 0.00px); gap above 29px, below 28px; body padding 16px/16px.

Fix verifies live. Leaving open for owner to re-close; no label changes.

QA re-verified on https://palette-dev.archfox.org (build contains merge commit 23cf315 / PR #199, CI docker success; pod digest 766ca6f97f2819 matches :dev image). **Dark mode toggle — works:** - Settings dark toggle is wired (`data-dark-wired="1"`); clicking it: `html.dark` removed, `data-preset` midnight -> midnight-light, body bg `rgb(36,27,48)` -> `rgb(243,239,249)`, `aria-pressed` true -> false, `localStorage.palette-dark` set to `"false"`. Verified at 1400x900 and 375x812. **Centering under title:** - 1400x900: title center x=700.00, toggle center x=699.99 (delta 0.01px); gap above toggle 29px, gap below to Theme section 28px; settings-body padding 16px top/bottom (even). - 375x812: title center x=187.50, toggle center x=187.50 (delta 0.00px); gap above 29px, below 28px; body padding 16px/16px. Fix verifies live. Leaving open for owner to re-close; no label changes.
fen added spent time 15 minutes 2026-09-10 17:24:57 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Assigned
Owner assigned: agent may pick this up
 Critical
critical severity (pentest triage)
 High
high severity (pentest triage)
 In Progress
Agent actively working on this
 Low
low severity (pentest triage)
 Medium
medium severity (pentest triage)
 Owner Review
Blocked on a human decision or design call - poslop must review before work proceeds
 QA
Implementation done, awaiting independent review agent
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
fen poslop
No Assignees
2 Participants
Notifications
Total Time Spent: 3 hours 55 minutes
fen
3 hours 55 minutes
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: poslop/palette#197