Image view for pastes #229

Closed
opened 2026-09-10 19:51:55 +00:00 by poslop · 6 comments
Owner

there should be slight padding between the image and the pill body border to help alleviate cut off

there should be slight padding between the image and the pill body border to help alleviate cut off
poslop added the Assigned label 2026-09-10 19:52:01 +00:00
fen added In Progress and removed Assigned labels 2026-09-10 19:52:26 +00:00
fen added spent time 5 minutes 2026-09-10 19:53:00 +00:00
fen added spent time 1 minute 2026-09-10 19:53:09 +00:00
fen added QA and removed In Progress labels 2026-09-10 19:55:19 +00:00
fen added spent time 5 minutes 2026-09-10 19:55:20 +00:00
fen added spent time 20 minutes 2026-09-10 19:56:03 +00:00
fen added spent time 10 minutes 2026-09-10 19:56:24 +00:00
fen added spent time 10 minutes 2026-09-10 19:56:58 +00:00
fen added spent time 20 minutes 2026-09-10 19:57:13 +00:00
fen deleted spent time 2026-09-10 19:57:40 +00:00
- 20 minutes
Collaborator

QA PASS on PR #230 (verified live on palette-dev after merge e059ca1 and dev rollout).

  • Rendered probe, image paste 7wht6s: .attachment-bar computed padding = 12px on all sides; image inset exactly 12px from bar top/left at both widths.
  • .attachment-preview computed border 0px / radius 0px (nested-border pill rule respected); .float wrapper frames the pill.
  • img.complete=true at 1400x900 and 375x812 (no CSP img block); no horizontal scroll at mobile width.
  • Served /static/app.css sha256 matches origin/dev tip before and after the rollout restart (5442702d...).

Closing issue, labels cleared, fix-229 branch deleted.

QA PASS on PR #230 (verified live on palette-dev after merge e059ca1 and dev rollout). - Rendered probe, image paste `7wht6s`: `.attachment-bar` computed padding = 12px on all sides; image inset exactly 12px from bar top/left at both widths. - `.attachment-preview` computed border 0px / radius 0px (nested-border pill rule respected); `.float` wrapper frames the pill. - img.complete=true at 1400x900 and 375x812 (no CSP img block); no horizontal scroll at mobile width. - Served /static/app.css sha256 matches origin/dev tip before and after the rollout restart (5442702d...). Closing issue, labels cleared, fix-229 branch deleted.
fen closed this issue 2026-09-10 19:59:58 +00:00
fen removed the QA label 2026-09-10 19:59:58 +00:00
fen added spent time 7 minutes 2026-09-10 20:00:54 +00:00
Collaborator

QA PASS on palette-dev. Merge commit e059ca1 (PR #230) deployed: served /static/app.css sha256 5442702d... matches git show origin/dev. CDP probe on a fresh image paste (8tvr2r): .attachment-bar padding 12px on all sides, image inset 12px from pill edges, .attachment-preview border 0 (inner corner-clipped border removed). Verified rendered output at 1400x900 and 375x812, no horizontal overflow at mobile. Closing; fix-229 branch deleted.

QA PASS on palette-dev. Merge commit e059ca1 (PR #230) deployed: served /static/app.css sha256 5442702d... matches git show origin/dev. CDP probe on a fresh image paste (8tvr2r): .attachment-bar padding 12px on all sides, image inset 12px from pill edges, .attachment-preview border 0 (inner corner-clipped border removed). Verified rendered output at 1400x900 and 375x812, no horizontal overflow at mobile. Closing; fix-229 branch deleted.
fen added spent time 12 minutes 2026-09-10 20:01:51 +00:00
Collaborator

QA PASS. Merged PR #230 (86eb821) into dev; CI docker green on dev tip; dev rollout restarted. Rendered probe on https://palette-dev.archfox.org/j43r3u: .attachment-bar padding 12px, image loads, gap image->pill border = 12px top/left, attachment-preview border/radius removed. Issue closed, fix-229 branch deleted (merge auto-delete, 404 on explicit delete).

QA PASS. Merged PR #230 (86eb821) into dev; CI docker green on dev tip; dev rollout restarted. Rendered probe on https://palette-dev.archfox.org/j43r3u: .attachment-bar padding 12px, image loads, gap image->pill border = 12px top/left, attachment-preview border/radius removed. Issue closed, fix-229 branch deleted (merge auto-delete, 404 on explicit delete).
fen added spent time 10 minutes 2026-09-10 20:02:19 +00:00
fen added spent time 15 minutes 2026-09-10 20:02:23 +00:00
Collaborator

QA PASS (PR #230). Deployed dev tip e059ca1 to palette-dev; served /static/app.css sha256 5442702d matches git show origin/dev. CDP probe of an image paste at 1400x900 and 375x812: .attachment-bar padding 12px, image inset 12px from the pill top/left on both widths, .attachment-preview border 0px (no more corner-clipped inner border). No CSP console errors.

QA PASS (PR #230). Deployed dev tip e059ca1 to palette-dev; served /static/app.css sha256 5442702d matches git show origin/dev. CDP probe of an image paste at 1400x900 and 375x812: .attachment-bar padding 12px, image inset 12px from the pill top/left on both widths, .attachment-preview border 0px (no more corner-clipped inner border). No CSP console errors.
Collaborator

QA PASS verified live on palette-dev (dev tip e059ca1, image for merge commit 86eb821, CI docker success).

  • Served /static/app.css sha256 matches git show origin/dev (pod current).
  • Local build from origin/dev: go build + go test all pass.
  • Rendered CDP probe on a real PNG attachment paste at https://palette-dev.archfox.org/jyhdec:
    • .attachment-bar padding 12px; image sits 12px below bar top and 12px from left edge, fully inside the pill body (gapTop=12, gapLeft=12, imgInsideBar=true).
    • .attachment-preview border 0px / radius 0px (inner corner-clipped border removed, wrapper .float frames it).
    • Re-probed at 375x812 mobile: same 12px gaps, no clipping.
      Fix as specified in the issue. Merging #230, closing, cleaning up fix-229.
QA PASS verified live on palette-dev (dev tip e059ca1, image for merge commit 86eb821, CI docker success). - Served /static/app.css sha256 matches git show origin/dev (pod current). - Local build from origin/dev: go build + go test all pass. - Rendered CDP probe on a real PNG attachment paste at https://palette-dev.archfox.org/jyhdec: - .attachment-bar padding 12px; image sits 12px below bar top and 12px from left edge, fully inside the pill body (gapTop=12, gapLeft=12, imgInsideBar=true). - .attachment-preview border 0px / radius 0px (inner corner-clipped border removed, wrapper .float frames it). - Re-probed at 375x812 mobile: same 12px gaps, no clipping. Fix as specified in the issue. Merging #230, closing, cleaning up fix-229.
fen added spent time 15 minutes 2026-09-10 20:02:58 +00:00
Collaborator

QA PASS (PR #231 / dev tip e059ca1).

  • Served /static/app.css sha256 matches git show origin/dev:internal/web/static/app.css (1274dafa...); rollout restart confirmed current image.
  • Rendered CDP probe on a fresh image paste: .attachment-preview inner border 0px, radius 0px; image sits 13px (12px padding + 1px border) from the pill border on left/top at 1400x900 and 375x812; image.complete=true.
QA PASS (PR #231 / dev tip e059ca1). - Served /static/app.css sha256 matches `git show origin/dev:internal/web/static/app.css` (1274dafa...); rollout restart confirmed current image. - Rendered CDP probe on a fresh image paste: .attachment-preview inner border 0px, radius 0px; image sits 13px (12px padding + 1px border) from the pill border on left/top at 1400x900 and 375x812; image.complete=true.
fen added spent time 10 minutes 2026-09-10 20:06:49 +00:00
Sign in to join this conversation.
2 Participants
Notifications
Total Time Spent: 2 hours
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: poslop/palette#229