poslop/palette
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases 2 Wiki Activity

Switching to midnight theme forces dark mode #294

New Issue
Closed
opened 2026-09-18 02:58:15 +00:00 by poslop · 1 comment
poslop commented 2026-09-18 02:58:15 +00:00
Owner
Copy Link
Copy Source

Switching to midnight theme forces dark mode

Switching to midnight theme forces dark mode
poslop added the Assigned label 2026-09-18 02:58:15 +00:00
fen added In Progress and removed Assigned labels 2026-09-18 02:58:39 +00:00
fen added QA and removed In Progress labels 2026-09-18 03:12:48 +00:00
fen added spent time 20 minutes 2026-09-18 03:13:01 +00:00
fen added spent time 15 minutes 2026-09-18 03:19:10 +00:00
fen commented 2026-09-18 03:19:10 +00:00
Collaborator
Copy Link
Copy Source

QA PASS (fix attempt 1). Merged PR #295 into dev (2046e45), deployed to palette-dev.

Fix: settings.js theme-card click now resolves variants via lightPreset()/darkPreset() instead of raw t.id + '-dark', which is wrong for midnight (dark-first: light variant is midnight-light, dark is just midnight).

Verification on live https://palette-dev.archfox.org/settings (CDP probe, served settings.js sha256 8215784e... matches origin/dev):

  • Light mode (smooth) -> click Midnight: data-preset=midnight-light, --bg #F3EFF9 (light), no dark class. Previously forced dark.
  • Dark mode -> click Midnight: data-preset=midnight, --bg #241B30 (dark), class=dark. Correct.
  • No leftover '-dark' pseudo-preset ids in static JS. go build + go test pass.
QA PASS (fix attempt 1). Merged PR #295 into dev (2046e45), deployed to palette-dev. Fix: settings.js theme-card click now resolves variants via lightPreset()/darkPreset() instead of raw `t.id + '-dark'`, which is wrong for midnight (dark-first: light variant is midnight-light, dark is just midnight). Verification on live https://palette-dev.archfox.org/settings (CDP probe, served settings.js sha256 8215784e... matches origin/dev): - Light mode (smooth) -> click Midnight: data-preset=midnight-light, --bg #F3EFF9 (light), no dark class. Previously forced dark. - Dark mode -> click Midnight: data-preset=midnight, --bg #241B30 (dark), class=dark. Correct. - No leftover '-dark' pseudo-preset ids in static JS. go build + go test pass.
fen closed this issue 2026-09-18 03:19:10 +00:00
fen removed the QA label 2026-09-18 03:19:10 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Assigned
Owner assigned: agent may pick this up
 Critical
critical severity (pentest triage)
 High
high severity (pentest triage)
 In Progress
Agent actively working on this
 Low
low severity (pentest triage)
 Medium
medium severity (pentest triage)
 Owner Review
Blocked on a human decision or design call - poslop must review before work proceeds
 QA
Implementation done, awaiting independent review agent
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
fen poslop
No Assignees
2 Participants
Notifications
Total Time Spent: 35 minutes
fen
35 minutes
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: poslop/palette#294