ratelimit: rightmost untrusted-hop-safe client IP (fixes #85) #89

Merged

poslop merged 1 commits from fix-85-xff into main 2026-09-09 15:59:29 +00:00

Conversation 0 Commits 1 Files Changed 2

+106 -1

poslop commented 2026-09-09 15:58:08 +00:00

Owner

Copy Link

Copy Source

clientIP() now takes the RIGHTMOST X-Forwarded-For entry (appended by the trusted Traefik proxy), falling back to X-Real-Ip then RemoteAddr. Spoofed leftmost XFF entries no longer rotate rate-limit buckets. Trust boundary documented in ratelimit.go. Regression tests: spoofed-first-XFF cannot bypass the create limit.

Fixes #85

clientIP() now takes the RIGHTMOST X-Forwarded-For entry (appended by the trusted Traefik proxy), falling back to X-Real-Ip then RemoteAddr. Spoofed leftmost XFF entries no longer rotate rate-limit buckets. Trust boundary documented in ratelimit.go. Regression tests: spoofed-first-XFF cannot bypass the create limit. Fixes #85

poslop added 1 commit 2026-09-09 15:58:08 +00:00

ratelimit: key on rightmost X-Forwarded-For entry (fixes #85) 3d1d5ee1fd

poslop merged commit 5b068faf8f into main 2026-09-09 15:59:29 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

Assigned

Owner assigned: agent may pick this up

Critical

critical severity (pentest triage)

High

high severity (pentest triage)

In Progress

Agent actively working on this

Low

low severity (pentest triage)

Medium

medium severity (pentest triage)

Owner Review

Blocked on a human decision or design call - poslop must review before work proceeds

QA

Implementation done, awaiting independent review agent

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

fen poslop

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: poslop/palette#89