fen
e54fbc36ef
Owner decision 2026-10-16: the cans feature (bundles of pastes, #4) was half-integrated and has zero prod usage; removing it eliminates four audit findings by deletion. Removed: - internal/api/cans.go and all can routes (/api/pastes/can, /api/cans/*, /can/{id}) plus handleCanPage/renderCan - is_can from /api/mine and /api/public responses - store layer: CanRow, can store funcs, paste_cans UNION in listings, cans sweep; reserved slugs 'can'/'cans' released - templates/can.html, can CSS, is_can badges in history.js/mine.js - cans tests (cans_test.go, cans_flow_test.go, cans_expiry_test.go, TestErrorCodeCanValidation) - docs/api.md cans section, README/LICENSE/docker-compose mentions Store migration: drops paste_cans only when empty (non-empty table is kept and logged; prod verified clean 2026-10-16) and drops the dormant pastes.can_id column. Covered by new TestMigrateDropsCansSchema. Security hardening (audit findings): pw_<id> (unlock) and tok_<id> (deletion-token) cookies now carry Secure: true in addition to HttpOnly + SameSite=Lax; all deployments are HTTPS-only. cookie_set_test now asserts Secure. go vet ./... and go test ./... pass.
89 lines
2.5 KiB
Go
89 lines
2.5 KiB
Go
package api
|
|
|
|
import (
|
|
"encoding/json"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
// #105: every validation path on create returns a machine-readable `code`
|
|
// alongside the human `error` message, so the new-page JS can map known
|
|
// codes to plain-language guidance.
|
|
|
|
func decodeErr(t *testing.T, rec *httptest.ResponseRecorder) (status int, errMsg, code string) {
|
|
t.Helper()
|
|
var got struct {
|
|
Error string `json:"error"`
|
|
Code string `json:"code"`
|
|
}
|
|
if err := json.Unmarshal(rec.Body.Bytes(), &got); err != nil {
|
|
t.Fatalf("bad json: %v (%s)", err, rec.Body.String())
|
|
}
|
|
return rec.Code, got.Error, got.Code
|
|
}
|
|
|
|
func postCreate(h http.Handler, body string) *httptest.ResponseRecorder {
|
|
req := httptest.NewRequest("POST", "/api/pastes", strings.NewReader(body))
|
|
rec := httptest.NewRecorder()
|
|
h.ServeHTTP(rec, req)
|
|
return rec
|
|
}
|
|
|
|
func TestErrorCodeContentEmpty(t *testing.T) {
|
|
h := testServer(t).routes()
|
|
_, _, code := decodeErr(t, postCreate(h, `{"content":" "}`))
|
|
if code != "content_empty" {
|
|
t.Fatalf("code = %q, want content_empty", code)
|
|
}
|
|
}
|
|
|
|
func TestErrorCodeContentTooLarge(t *testing.T) {
|
|
h := testServer(t).routes()
|
|
big := strings.Repeat("x", 6*1024*1024) // over the 5MB test cap
|
|
_, _, code := decodeErr(t, postCreate(h, `{"content":"`+big+`"}`))
|
|
if code != "content_too_large" {
|
|
t.Fatalf("code = %q, want content_too_large", code)
|
|
}
|
|
}
|
|
|
|
func TestErrorCodeSlugTaken(t *testing.T) {
|
|
h := testServer(t).routes()
|
|
if rec := postCreate(h, `{"content":"a","custom_slug":"taken-slug"}`); rec.Code != 201 {
|
|
t.Fatalf("seed create: %d %s", rec.Code, rec.Body.String())
|
|
}
|
|
_, _, code := decodeErr(t, postCreate(h, `{"content":"b","custom_slug":"taken-slug"}`))
|
|
if code != "slug_taken" {
|
|
t.Fatalf("code = %q, want slug_taken", code)
|
|
}
|
|
}
|
|
|
|
func TestErrorCodeSlugInvalid(t *testing.T) {
|
|
h := testServer(t).routes()
|
|
_, _, code := decodeErr(t, postCreate(h, `{"content":"a","custom_slug":"bad slug!"}`))
|
|
if code != "slug_invalid" {
|
|
t.Fatalf("code = %q, want slug_invalid", code)
|
|
}
|
|
}
|
|
|
|
func TestErrorCodeExpiryInvalid(t *testing.T) {
|
|
h := testServer(t).routes()
|
|
_, _, code := decodeErr(t, postCreate(h, `{"content":"a","expires_in":"2s"}`))
|
|
if code != "expiry_invalid" {
|
|
t.Fatalf("code = %q, want expiry_invalid", code)
|
|
}
|
|
}
|
|
|
|
func TestErrorCodeRateLimited(t *testing.T) {
|
|
h := testServer(t).routes()
|
|
var code string
|
|
for i := 0; i < 20; i++ {
|
|
_, _, code = decodeErr(t, postCreate(h, `{"content":"a"}`))
|
|
if code == "rate_limited" {
|
|
return
|
|
}
|
|
}
|
|
t.Fatalf("never got rate_limited, last code = %q", code)
|
|
}
|