Settings: dark toggle above theme list; midnight card light/dark rows swapped #132

Closed
opened 2026-09-10 03:33:18 +00:00 by fen · 1 comment
Collaborator

Two follow-ups to #127/#128:

  1. On /settings the dark mode toggle button should appear ABOVE the theme pair list (currently it does not).
  2. On the Midnight pair card, the LIGHT variant (midnight-light) is not the top row — dark swatches appear on top. Midnight is dark-first (its variant is the light one), so the presetColors read order is inverted for that card. Fix ordering generically so every card shows light-variant swatches on top, dark on bottom.
Two follow-ups to #127/#128: 1. On /settings the dark mode toggle button should appear ABOVE the theme pair list (currently it does not). 2. On the Midnight pair card, the LIGHT variant (midnight-light) is not the top row — dark swatches appear on top. Midnight is dark-first (its variant is the light one), so the presetColors read order is inverted for that card. Fix ordering generically so every card shows light-variant swatches on top, dark on bottom.
fen added spent time 25 seconds 2026-09-10 03:33:24 +00:00
fen added the In Progress label 2026-09-10 03:33:30 +00:00
fen added QA and removed In Progress labels 2026-09-10 03:38:57 +00:00
fen added spent time 2 seconds 2026-09-10 13:18:33 +00:00
fen closed this issue 2026-09-10 13:23:29 +00:00
Author
Collaborator

QA passed (#132). Verified on live palette-dev after rollout restart: dark toggle renders ABOVE the Theme heading/theme-grid in the settings menu; midnight pair card shows light variant (midnight-light, bg #F3EFF9) top row and dark (midnight, bg #241B30) bottom row via generic lightPreset()/darkPreset() resolution; line wrap toggle (Editor section, from dev) preserved after rebase; no CSP violations in rendered DOM. go build + go test pass; PR rebased onto dev (dev had moved ahead with #136/#150), CI green on rebased head and merge commit b0a58d6, docker dev image rebuilt. PR #134 merged.

QA passed (#132). Verified on live palette-dev after rollout restart: dark toggle renders ABOVE the Theme heading/theme-grid in the settings menu; midnight pair card shows light variant (midnight-light, bg #F3EFF9) top row and dark (midnight, bg #241B30) bottom row via generic lightPreset()/darkPreset() resolution; line wrap toggle (Editor section, from dev) preserved after rebase; no CSP violations in rendered DOM. go build + go test pass; PR rebased onto dev (dev had moved ahead with #136/#150), CI green on rebased head and merge commit b0a58d6, docker dev image rebuilt. PR #134 merged.
fen added spent time 10 seconds 2026-09-10 13:29:34 +00:00
fen added spent time 36 minutes 2026-09-10 13:54:10 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Total Time Spent: 37 minutes
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: poslop/palette#132