QA FAIL (PR #191): wrong feature for issue #187. Issue is 'website tab icon' (favicon), but PR head fix-187 (1a8da8c) implements the #168 notification-pill rework: its commit history is entirely #167/#168/#169/#171 work, the PR files diff is empty, and no favicon/icon asset or head-template change exists anywhere in the branch. Additionally fix-187's tip is an ancestor of current dev (dev tip 9621faa0 already contains it), so merging would be a no-op. PR not merged; issue stays open. A real fix-187 favicon branch is needed.
QA FAIL (PR #191): wrong feature for issue #187. Issue is 'website tab icon' (favicon), but PR head fix-187 (1a8da8c) implements the #168 notification-pill rework: its commit history is entirely #167/#168/#169/#171 work, the PR files diff is empty, and no favicon/icon asset or head-template change exists anywhere in the branch. Additionally fix-187's tip is an ancestor of current dev (dev tip 9621faa0 already contains it), so merging would be a no-op. PR not merged; issue stays open. A real fix-187 favicon branch is needed.
fen
added spent time 15 minutes2026-09-10 16:54:33 +00:00
PR #191 is empty: its branch fix-187 (1a8da8cd) is an ancestor of current dev (9621faa0) — compare dev...fix-187 shows 0 commits ahead and 0 changed files. Nothing was merged or added.
Evidence:
No favicon asset exists anywhere under internal/web (no favicon.ico/icon.svg in the tree).
internal/web/templates/layout.html has no .
PR title/body also describe an unrelated change ("Paste Created pill"), suggesting the branch was created before the actual favicon work.
Fix path: create a paint-can/palette icon as an embedded static asset (e.g. internal/web/static/favicon.svg + web.go go:embed), add to layout.html <head> (CSP img-src 'self' data: already permits it), go build ./... && go test ./..., then push to fix-187 and reopen/retarget the PR.
Issue left open; QA label retained.
QA FAIL (PR #191 review)
PR #191 is empty: its branch fix-187 (1a8da8cd) is an ancestor of current dev (9621faa0) — compare dev...fix-187 shows 0 commits ahead and 0 changed files. Nothing was merged or added.
Evidence:
- No favicon asset exists anywhere under internal/web (no favicon.ico/icon.svg in the tree).
- internal/web/templates/layout.html has no <link rel="icon">.
- PR title/body also describe an unrelated change ("Paste Created pill"), suggesting the branch was created before the actual favicon work.
Fix path: create a paint-can/palette icon as an embedded static asset (e.g. internal/web/static/favicon.svg + web.go go:embed), add <link rel="icon" href="/static/favicon.svg"> to layout.html <head> (CSP img-src 'self' data: already permits it), go build ./... && go test ./..., then push to fix-187 and reopen/retarget the PR.
Issue left open; QA label retained.
fen
added spent time 6 minutes2026-09-10 16:54:46 +00:00
fen
added spent time 8 minutes2026-09-10 16:57:20 +00:00
QA FAIL re-check (PR #191, favicon for #187): confirmed the earlier FAIL verdict. PR head 1a8da8c is an ancestor of current dev (merge-base = PR head; dev...fix-187 diff is 0 files). No favicon asset or link rel=icon exists anywhere under internal/web (git grep over templates+static returns nothing). The PR title's 'created pill' wording is unrelated #168 naming. Nothing to merge or deploy: fix-187 contains no implementation of the tab icon. Issue stays open; implementation needs a real favicon (e.g. self-hosted SVG/ico allowed by img-src 'self' data: plus a head link in layout.html).
QA FAIL re-check (PR #191, favicon for #187): confirmed the earlier FAIL verdict. PR head 1a8da8c is an ancestor of current dev (merge-base = PR head; dev...fix-187 diff is 0 files). No favicon asset or link rel=icon exists anywhere under internal/web (git grep over templates+static returns nothing). The PR title's 'created pill' wording is unrelated #168 naming. Nothing to merge or deploy: fix-187 contains no implementation of the tab icon. Issue stays open; implementation needs a real favicon (e.g. self-hosted SVG/ico allowed by img-src 'self' data: plus a head link in layout.html).
fen
removed the QA label 2026-09-10 16:57:48 +00:00
fen
added the In Progress label 2026-09-10 16:58:48 +00:00
fen
added spent time 15 minutes2026-09-10 16:59:16 +00:00
Live verification note: palette-dev was still serving a stale pod (favicon 404, no link rel=icon in HTML) after the #196 merge. Rollout restart done; confirmed live now: GET /static/favicon.svg returns 200 image/svg+xml and the rendered homepage includes . Fix verified, no further work.
Live verification note: palette-dev was still serving a stale pod (favicon 404, no link rel=icon in HTML) after the #196 merge. Rollout restart done; confirmed live now: GET /static/favicon.svg returns 200 image/svg+xml and the rendered homepage includes <link rel="icon" type="image/svg+xml" href="/static/favicon.svg">. Fix verified, no further work.
QA PASS (PR #196): favicon verified live on palette-dev.
Merged PR #196 (head fix-187-favicon 2a21251, rebased/current on dev) via tea; merge commit b603b29 on dev.
CI: test + docker both success on the merge commit (run 222).
Deployed: rollout restart in palette-dev, new pod palette-75bcd949d6-knd9j serving.
Live verify: served HTML on /new contains (headless chromium dump-dom count = 1); GET /static/favicon.svg -> 200 image/svg+xml 560 bytes; img-src allows data: so nothing blocks it.
QA PASS (PR #196): favicon verified live on palette-dev.
- Merged PR #196 (head fix-187-favicon 2a21251, rebased/current on dev) via tea; merge commit b603b29 on dev.
- CI: test + docker both success on the merge commit (run 222).
- Deployed: rollout restart in palette-dev, new pod palette-75bcd949d6-knd9j serving.
- Live verify: served HTML on /new contains <link rel="icon" type="image/svg+xml" href="/static/favicon.svg"> (headless chromium dump-dom count = 1); GET /static/favicon.svg -> 200 image/svg+xml 560 bytes; img-src allows data: so nothing blocks it.
- Console: no CSP violations during headless load.
Closing #187; deleting fix-187-favicon.
fen
added spent time 8 minutes2026-09-10 17:11:02 +00:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
there should be a tiny icon for browsers tabs. it can be a tiny paint can or paint palette either are fine for now.
QA FAIL (PR #191): wrong feature for issue #187. Issue is 'website tab icon' (favicon), but PR head fix-187 (
1a8da8c) implements the #168 notification-pill rework: its commit history is entirely #167/#168/#169/#171 work, the PR files diff is empty, and no favicon/icon asset or head-template change exists anywhere in the branch. Additionally fix-187's tip is an ancestor of current dev (dev tip9621faa0already contains it), so merging would be a no-op. PR not merged; issue stays open. A real fix-187 favicon branch is needed.QA FAIL (PR #191 review)
PR #191 is empty: its branch fix-187 (
1a8da8cd) is an ancestor of current dev (9621faa0) — compare dev...fix-187 shows 0 commits ahead and 0 changed files. Nothing was merged or added.Evidence:
Fix path: create a paint-can/palette icon as an embedded static asset (e.g. internal/web/static/favicon.svg + web.go go:embed), add to layout.html <head> (CSP img-src 'self' data: already permits it), go build ./... && go test ./..., then push to fix-187 and reopen/retarget the PR.
Issue left open; QA label retained.
QA FAIL re-check (PR #191, favicon for #187): confirmed the earlier FAIL verdict. PR head
1a8da8cis an ancestor of current dev (merge-base = PR head; dev...fix-187 diff is 0 files). No favicon asset or link rel=icon exists anywhere under internal/web (git grep over templates+static returns nothing). The PR title's 'created pill' wording is unrelated #168 naming. Nothing to merge or deploy: fix-187 contains no implementation of the tab icon. Issue stays open; implementation needs a real favicon (e.g. self-hosted SVG/ico allowed by img-src 'self' data: plus a head link in layout.html).Live verification note: palette-dev was still serving a stale pod (favicon 404, no link rel=icon in HTML) after the #196 merge. Rollout restart done; confirmed live now: GET /static/favicon.svg returns 200 image/svg+xml and the rendered homepage includes . Fix verified, no further work.
QA PASS (PR #196): favicon verified live on palette-dev.
2a21251, rebased/current on dev) via tea; merge commitb603b29on dev.Closing #187; deleting fix-187-favicon.