Sorting arrows #209
Notifications
Total Time Spent: 4 hours 19 minutes
fen
4 hours 19 minutes
No due date set.
Dependencies
No dependencies set.
Reference: poslop/palette#209
Reference in New Issue
Block a user
The arrows to indicate sort direction look good right now but they should be to the right of the column label not left. this will allow the column label to perfectly align its text with the contents of its column. The current padding spacing is good it just needs to be the right of the text instead.
QA PASS: merged #212 (rebased onto dev first, its pre-#210 base would have reverted the #210 delete-column fix), CI docker green, deployed to palette-dev. Served app.css confirmed with
padding-right: 24px/position: absolute; right: 8px; /mine renders with sort-ind spans present and page healthy.The arrows for for sorting should be immiately to the right of the column label text. they shouldnt be right of the column they should be aligned to be right of the label text.
PR #212 merged into dev (sort arrows right of column labels). Moving to QA.
PR #212 merged into dev (sort arrows right of column labels). Moving to QA.
QA PASS on live palette-dev (dev tip
13884ca, CI docker success, rollout restarted; served app.css/mine.js sha256 match origin/dev). CDP rendered probe at 1400x900: .sort-ind spans render RIGHT of the label text in all six sortable columns (spanLeft > textRight for Paste/Language/Size/Created/URL/ID), and header labels left-align with their column contents (th.x == td.x). Fix #212 verified; closing.QA PASS r2: PR #218 verified on live palette-dev (served app.css sha256 matches origin/dev tip aa139a57, /mine renders label-then-arrow markup with 6 sort indicators, CI test+docker green, rollout complete). Owner revision of #212 landed as requested: arrows now sit immediately right of the label text, inline with a 6px gap. Closing.
QA PASS: verified PR #218 (already merged to dev,
700b825) live on palette-dev. Served app.css sha256 matches dev tip; rollout restarted after CI docker went green (first restart had served the stale image). Rendered CDP probe on /history and /mine: every sort arrow sits exactly 6px right of its label text, label text left-aligned with column contents (13 columns checked, gap=6 consistently). Zero CSP violations. Issue closed, branch cleaned. Logged 15m QA time.