Adds a 'GitHub' anchor to the topbar nav, immediately after the existing Git link, following the same convention:
Inline stroke-based external-link SVG icon (.ext class), identical to the Git link — no CSS changes needed.
target="_blank", rel="noopener noreferrer", aria-label="GitHub (opens in a new tab)".
Note: the href (https://github.com/poslop) is a placeholder pending Caleb's real social link — please confirm before merge.
Verified: go vet ./... and go test ./... both pass.
Adds a 'GitHub' anchor to the topbar nav, immediately after the existing Git link, following the same convention:
- Inline stroke-based external-link SVG icon (`.ext` class), identical to the Git link — no CSS changes needed.
- `target="_blank"`, `rel="noopener noreferrer"`, `aria-label="GitHub (opens in a new tab)"`.
**Note:** the href (`https://github.com/poslop`) is a placeholder pending Caleb's real social link — please confirm before merge.
Verified: `go vet ./...` and `go test ./...` both pass.
Add a 'GitHub' anchor after the existing Git link in the topbar nav,
reusing the inline stroke-based .ext external-link SVG icon so no CSS
changes are needed. href is a placeholder (https://github.com/poslop)
pending Caleb's real social link.
Out-of-scope CSS change: the app.css hunk reverts the #209 r2 sort-arrow fix on dev (inline right of the label with a fixed margin-left) back to an absolutely positioned right:8px floater pinned to the column edge. That is exactly the pattern the owner rejected for #209 (a floater drifts off the label text in wider columns). Unrelated to the GitHub-link scope and cannot merge.
The GitHub href (https://github.com/poslop) is a placeholder the PR itself flags as pending the owner's real link, so merging would put a dead link in the topbar.
The layout.html hunk itself (anchor + ext SVG after the Git link) is fine and matches the existing convention. Rework: rebase the layout change alone onto current dev (drop the app.css hunk) and fill in the real URL once the owner provides it.
QA FAIL. Two blockers, one of them a regression:
1. Out-of-scope CSS change: the app.css hunk reverts the #209 r2 sort-arrow fix on dev (inline right of the label with a fixed margin-left) back to an absolutely positioned right:8px floater pinned to the column edge. That is exactly the pattern the owner rejected for #209 (a floater drifts off the label text in wider columns). Unrelated to the GitHub-link scope and cannot merge.
2. The GitHub href (https://github.com/poslop) is a placeholder the PR itself flags as pending the owner's real link, so merging would put a dead link in the topbar.
The layout.html hunk itself (anchor + ext SVG after the Git link) is fine and matches the existing convention. Rework: rebase the layout change alone onto current dev (drop the app.css hunk) and fill in the real URL once the owner provides it.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Adds a 'GitHub' anchor to the topbar nav, immediately after the existing Git link, following the same convention:
.extclass), identical to the Git link — no CSS changes needed.target="_blank",rel="noopener noreferrer",aria-label="GitHub (opens in a new tab)".Note: the href (
https://github.com/poslop) is a placeholder pending Caleb's real social link — please confirm before merge.Verified:
go vet ./...andgo test ./...both pass.QA FAIL. Two blockers, one of them a regression:
Out-of-scope CSS change: the app.css hunk reverts the #209 r2 sort-arrow fix on dev (inline right of the label with a fixed margin-left) back to an absolutely positioned right:8px floater pinned to the column edge. That is exactly the pattern the owner rejected for #209 (a floater drifts off the label text in wider columns). Unrelated to the GitHub-link scope and cannot merge.
The GitHub href (https://github.com/poslop) is a placeholder the PR itself flags as pending the owner's real link, so merging would put a dead link in the topbar.
The layout.html hunk itself (anchor + ext SVG after the Git link) is fine and matches the existing convention. Rework: rebase the layout change alone onto current dev (drop the app.css hunk) and fill in the real URL once the owner provides it.
Pull request closed