Fix #221 follow-up: summary pill size for attachment pastes #228

Merged
fen merged 1 commits from fix-221-r2 into dev 2026-09-10 19:33:51 +00:00
Collaborator

Ref #221

Follow-up delta to merged PR #224: the details grid got the attachment size, but the summary pill still used humanSize(len(row.Content)) which reads 0 B for file pastes (text content is empty). Verified locally: image paste summary now shows the attachment size; text paste unchanged; raw view still serves the image.

Ref #221 Follow-up delta to merged PR #224: the details grid got the attachment size, but the summary pill still used humanSize(len(row.Content)) which reads 0 B for file pastes (text content is empty). Verified locally: image paste summary now shows the attachment size; text paste unchanged; raw view still serves the image.
fen added 1 commit 2026-09-10 19:32:01 +00:00
#221: summary pill size must come from the attachment blob for file pastes
CI / docker (pull_request) Skipped
CI / test (pull_request) Successful in 43s
d18bbb7064
The merged #224 fix covered the details grid but left the summary
pill using humanSize(len(row.Content)), which reads 0 for attachment
pastes (text content is empty). Use the attachment size there too.
fen merged commit e589428315 into dev 2026-09-10 19:33:51 +00:00
fen added the QA label 2026-09-10 19:34:36 +00:00
Author
Collaborator

QA PASS (verified live on palette-dev):

  • PR #228 head d18bbb7 is an ancestor of dev (merge commit e589428), CI test + docker both green on dev tip.
  • Live check on https://palette-dev.archfox.org: created a 4000-byte image paste via multipart; the paste page summary pill renders text · 3.9 KB (not 0 B), image renders via /f/ attachment URL, and /raw/w78rg2 serves the PNG (200, image/png, 4000 bytes).
  • The fix path (summary size from attachment.Size for file pastes) is exercised end to end on the deployed server; no deploy restart was needed (pod already serving dev-tip behavior).

Branch fix-221-r2: already auto-deleted by the merge (confirmed via GET /branches).

QA PASS (verified live on palette-dev): - PR #228 head d18bbb7 is an ancestor of dev (merge commit e589428), CI test + docker both green on dev tip. - Live check on https://palette-dev.archfox.org: created a 4000-byte image paste via multipart; the paste page summary pill renders `text · 3.9 KB` (not `0 B`), image renders via /f/ attachment URL, and /raw/w78rg2 serves the PNG (200, image/png, 4000 bytes). - The fix path (summary size from attachment.Size for file pastes) is exercised end to end on the deployed server; no deploy restart was needed (pod already serving dev-tip behavior). Branch fix-221-r2: already auto-deleted by the merge (confirmed via GET /branches).
fen added spent time 15 minutes 2026-09-10 19:36:33 +00:00
fen removed the QA label 2026-09-10 19:36:39 +00:00
fen added spent time 12 minutes 2026-09-10 19:37:12 +00:00
Author
Collaborator

QA PASS (PR #228, verified live on palette-dev against dev merge e589428):

  • created image paste mh4uka (attachment size 20091 B): paste page summary shows 'text · 19.6 KB · 0 views' (attachment size, no 0 B)
  • /raw/mh4uka -> 200 image/jpeg, 20091 bytes served
  • /f/.../qa228.jpg -> 200 image/jpeg, Content-Disposition inline, 20091 bytes
  • text paste regression n4rryx: summary shows correct 22 B
QA PASS (PR #228, verified live on palette-dev against dev merge e589428): - created image paste mh4uka (attachment size 20091 B): paste page summary shows 'text · 19.6 KB · 0 views' (attachment size, no 0 B) - /raw/mh4uka -> 200 image/jpeg, 20091 bytes served - /f/.../qa228.jpg -> 200 image/jpeg, Content-Disposition inline, 20091 bytes - text paste regression n4rryx: summary shows correct 22 B
fen added spent time 7 minutes 2026-09-10 19:43:51 +00:00
Sign in to join this conversation.