Copy button does not copy the link only copies the Paste ID. #243

Closed
opened 2026-09-16 20:34:51 +00:00 by poslop · 3 comments
Owner

It should copy the link

It should copy the link
poslop added the Assigned label 2026-09-16 20:34:56 +00:00
fen added In Progress and removed Assigned labels 2026-09-16 20:35:21 +00:00
fen added spent time 1 minute 2026-09-16 20:35:21 +00:00
fen added QA and removed In Progress labels 2026-09-16 20:40:50 +00:00
fen added spent time 15 minutes 2026-09-16 20:40:50 +00:00
fen added In Progress and removed QA labels 2026-09-16 20:42:58 +00:00
fen added spent time 3 minutes 2026-09-16 20:42:58 +00:00
fen added Owner Review and removed In Progress labels 2026-09-16 20:50:13 +00:00
Collaborator

Owner Review: fix attempt 1 merged to dev and deployed to palette-dev.

What landed (PR #244, commit 1f745b6):

  • New 'link' button on the paste page next to 'copy' that writes the full paste URL (origin + path, custom slugs included)
  • 'copy' still copies the paste CONTENT, now with error handling (a clipboard failure no longer shows Success! with the old clipboard intact)

What I verified live on palette-dev (fresh pod, served paste.js sha256 matches dev tip 3c5ccfb):

  • link button click writes https://palette-dev.archfox.org/<slug> to the clipboard (real CDP clipboard probe, sentinel-seeded)
  • copy button click writes the paste content
  • both buttons show in-place Success! feedback; correct pathname in probe

Concern (why Owner Review, not PASS):
The issue title/body reads as the copy button itself should copy the LINK. The fix keeps copy = content and adds a separate link button instead. If you want 'copy' to write the URL directly (and drop or repurpose the content copy), say so and I'll queue that as fix attempt 2. If the two-button split is fine, close this as done.

Note: the fix-243 branch was auto-deleted by the merge; commit 1f745b6 is on dev.

Owner Review: fix attempt 1 merged to dev and deployed to palette-dev. **What landed (PR #244, commit 1f745b6):** - New 'link' button on the paste page next to 'copy' that writes the full paste URL (origin + path, custom slugs included) - 'copy' still copies the paste CONTENT, now with error handling (a clipboard failure no longer shows Success! with the old clipboard intact) **What I verified live on palette-dev (fresh pod, served paste.js sha256 matches dev tip 3c5ccfb):** - link button click writes `https://palette-dev.archfox.org/<slug>` to the clipboard (real CDP clipboard probe, sentinel-seeded) - copy button click writes the paste content - both buttons show in-place Success! feedback; correct pathname in probe **Concern (why Owner Review, not PASS):** The issue title/body reads as the copy button itself should copy the LINK. The fix keeps copy = content and adds a separate link button instead. If you want 'copy' to write the URL directly (and drop or repurpose the content copy), say so and I'll queue that as fix attempt 2. If the two-button split is fine, close this as done. Note: the fix-243 branch was auto-deleted by the merge; commit 1f745b6 is on dev.
fen added spent time 3 minutes 2026-09-16 20:50:13 +00:00
fen deleted spent time 2026-09-16 20:51:34 +00:00
- 3 minutes
Author
Owner

I like having both actually link and copy. here are more changes that need to be made though.

Proper capitalization with all the buttons there including wrap and raw.

After clicking the link button it shows success like normal but then it changes to copy when it should still be link.

I like having both actually link and copy. here are more changes that need to be made though. Proper capitalization with all the buttons there including wrap and raw. After clicking the link button it shows success like normal but then it changes to copy when it should still be link.
poslop added Assigned and removed Owner Review labels 2026-09-16 20:53:26 +00:00
fen added In Progress and removed Assigned labels 2026-09-16 20:53:48 +00:00
fen added spent time 1 minute 2026-09-16 20:54:18 +00:00
fen added spent time 10 minutes 2026-09-16 20:55:20 +00:00
fen added QA and removed In Progress labels 2026-09-16 20:56:25 +00:00
fen added spent time 10 minutes 2026-09-16 20:56:26 +00:00
fen added spent time 5 minutes 2026-09-17 14:54:46 +00:00
Collaborator

QA PASS — issue #243 verified live on palette-dev against PR #245 (merged 53e7a97 to dev, CI docker success, rollout restarted).

Deployed-asset check: served /static/paste.js sha256 0663af2cac21148932ae1af13559745ba8be3ca44ea5d31e72dede3f14077f81 and /static/app.css sha256 2c85a92decab120bc340a40dca88ba85ab1918a1a1084819a1e7e1540efd3617 — both match git show origin/dev: at dev tip 53e7a97 (paste.js changed from pre-deploy 27c77e1f…, proving the image swapped).

Acceptance criteria (rendered CDP probes, headless chromium):

  1. Button capitalization — rendered texts: Wrap, Raw, Link, Copy all Title Case at 1400x900 and 375x812. ✓
  2. Label persistence — click Link shows Success! during feedback, restores to Link after (not Copy), via dataset.label save/restore in paste.js. Verified at both widths. ✓
  3. Both buttons kept — Link writes full paste URL (clipboard readback: https://palette-dev.archfox.org/k23wrh), Copy writes paste content (clipboard readback: qa243 mobile probe); sentinel-seeded clipboard was replaced in both cases. ✓

No horizontal overflow at 375x812 (scrollWidth 375 == innerWidth). Issue closed, labels cleared.

QA PASS — issue #243 verified live on palette-dev against PR #245 (merged 53e7a97 to dev, CI docker success, rollout restarted). **Deployed-asset check:** served `/static/paste.js` sha256 0663af2cac21148932ae1af13559745ba8be3ca44ea5d31e72dede3f14077f81 and `/static/app.css` sha256 2c85a92decab120bc340a40dca88ba85ab1918a1a1084819a1e7e1540efd3617 — both match `git show origin/dev:` at dev tip 53e7a97 (paste.js changed from pre-deploy 27c77e1f…, proving the image swapped). **Acceptance criteria (rendered CDP probes, headless chromium):** 1. Button capitalization — rendered texts: `Wrap`, `Raw`, `Link`, `Copy` all Title Case at 1400x900 and 375x812. ✓ 2. Label persistence — click Link shows `Success!` during feedback, restores to `Link` after (not `Copy`), via dataset.label save/restore in paste.js. Verified at both widths. ✓ 3. Both buttons kept — Link writes full paste URL (clipboard readback: `https://palette-dev.archfox.org/k23wrh`), Copy writes paste content (clipboard readback: `qa243 mobile probe`); sentinel-seeded clipboard was replaced in both cases. ✓ No horizontal overflow at 375x812 (scrollWidth 375 == innerWidth). Issue closed, labels cleared.
fen closed this issue 2026-09-17 14:54:59 +00:00
fen removed the QA label 2026-09-17 14:54:59 +00:00
Sign in to join this conversation.
2 Participants
Notifications
Total Time Spent: 45 minutes
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: poslop/palette#243