Copy button does not copy the link only copies the Paste ID. #243
Notifications
Total Time Spent: 45 minutes
fen
45 minutes
No due date set.
Dependencies
No dependencies set.
Reference: poslop/palette#243
Reference in New Issue
Block a user
It should copy the link
Owner Review: fix attempt 1 merged to dev and deployed to palette-dev.
What landed (PR #244, commit
1f745b6):What I verified live on palette-dev (fresh pod, served paste.js sha256 matches dev tip
3c5ccfb):https://palette-dev.archfox.org/<slug>to the clipboard (real CDP clipboard probe, sentinel-seeded)Concern (why Owner Review, not PASS):
The issue title/body reads as the copy button itself should copy the LINK. The fix keeps copy = content and adds a separate link button instead. If you want 'copy' to write the URL directly (and drop or repurpose the content copy), say so and I'll queue that as fix attempt 2. If the two-button split is fine, close this as done.
Note: the fix-243 branch was auto-deleted by the merge; commit
1f745b6is on dev.I like having both actually link and copy. here are more changes that need to be made though.
Proper capitalization with all the buttons there including wrap and raw.
After clicking the link button it shows success like normal but then it changes to copy when it should still be link.
QA PASS — issue #243 verified live on palette-dev against PR #245 (merged
53e7a97to dev, CI docker success, rollout restarted).Deployed-asset check: served
/static/paste.jssha256 0663af2cac21148932ae1af13559745ba8be3ca44ea5d31e72dede3f14077f81 and/static/app.csssha256 2c85a92decab120bc340a40dca88ba85ab1918a1a1084819a1e7e1540efd3617 — both matchgit show origin/dev:at dev tip53e7a97(paste.js changed from pre-deploy 27c77e1f…, proving the image swapped).Acceptance criteria (rendered CDP probes, headless chromium):
Wrap,Raw,Link,Copyall Title Case at 1400x900 and 375x812. ✓Success!during feedback, restores toLinkafter (notCopy), via dataset.label save/restore in paste.js. Verified at both widths. ✓https://palette-dev.archfox.org/k23wrh), Copy writes paste content (clipboard readback:qa243 mobile probe); sentinel-seeded clipboard was replaced in both cases. ✓No horizontal overflow at 375x812 (scrollWidth 375 == innerWidth). Issue closed, labels cleared.