image attachments scale to fit (object-fit contain, max-height min(70vh,720px)), no code/text box under the image
wrap/copy buttons hidden for image pastes
size in stats summary/details shows the attachment size (was 0 B since Content is empty for file pastes)
/raw/{id} on a file paste serves the image inline with correct mime + filename instead of an empty body
Verified locally: uploaded jpeg, paste view shows scaled preview and no code box, /raw returns the jpeg bytes (image/jpeg, inline); text paste regression checked. Closes#221
- image attachments scale to fit (object-fit contain, max-height min(70vh,720px)), no code/text box under the image
- wrap/copy buttons hidden for image pastes
- size in stats summary/details shows the attachment size (was 0 B since Content is empty for file pastes)
- /raw/{id} on a file paste serves the image inline with correct mime + filename instead of an empty body
Verified locally: uploaded jpeg, paste view shows scaled preview and no code box, /raw returns the jpeg bytes (image/jpeg, inline); text paste regression checked. Closes #221
- paste view: image attachments render in a scalable preview (max-height
min(70vh, 720px), object-fit contain) and the code box is omitted;
wrap/copy buttons hidden for image pastes
- SizeHuman/stats summary show the attachment size for file pastes
(row.Content is empty for file pastes, was showing 0 B)
- /raw/{id} on a file paste streams the attachment bytes inline with its
sniffed mime and filename instead of an empty text/plain body
State saved before VM cleanup (fen-vm storage trim). This worktree was interrupted mid-task.
Where it stands:
Local branch fix-221 at 1bfefe0 contains a divergent approach from the pushed origin/fix-221 (98ea7ee): local version reads attachment size/line info into renderPaste (SizeBytes from blob, sizeHuman fix for attachment pastes) and adds IsImagePaste template var; origin version instead uses AttachmentImage flag + renders image directly in paste.html. The two implement the same #221 goal differently.
A merge between them was in progress with conflicts in server.go, app.css, paste.html, web.go. Conflicts were aborted (not resolved); the local working tree was preserved and pushed as branch fix-221-wip (1bfefe0) so nothing is lost.
Decision needed: pick one approach (local blob-size version looks more complete: it fixes wrong size display for attachment pastes too), rebase/redo the merge, QA, then PR.
Nothing was deleted; all palette worktrees under /home/fen/* will be cleaned only after this state was committed upstream.
**State saved before VM cleanup (fen-vm storage trim).** This worktree was interrupted mid-task.
Where it stands:
- Local branch `fix-221` at `1bfefe0` contains a divergent approach from the pushed `origin/fix-221` (`98ea7ee`): local version reads attachment size/line info into renderPaste (SizeBytes from blob, sizeHuman fix for attachment pastes) and adds `IsImagePaste` template var; origin version instead uses `AttachmentImage` flag + renders image directly in paste.html. The two implement the same #221 goal differently.
- A merge between them was in progress with conflicts in server.go, app.css, paste.html, web.go. Conflicts were aborted (not resolved); the local working tree was preserved and pushed as branch **`fix-221-wip`** (1bfefe0) so nothing is lost.
- Decision needed: pick one approach (local blob-size version looks more complete: it fixes wrong size display for attachment pastes too), rebase/redo the merge, QA, then PR.
Nothing was deleted; all palette worktrees under /home/fen/* will be cleaned only after this state was committed upstream.
Superseded by #224 (branch fix-221, commit 98ea7ee), which was merged into dev and closed issue #221. This duplicate PR from a parallel run is closed; its branch is removed.
Superseded by #224 (branch fix-221, commit 98ea7ee), which was merged into dev and closed issue #221. This duplicate PR from a parallel run is closed; its branch is removed.
Closing as superseded: PR #224 for the same issue #221 was QA-verified and merged to dev (cb58a51) and is live on palette-dev. Scope of this PR (scaled image view, no code box, raw image serving, attachment size) is covered by #224.
Closing as superseded: PR #224 for the same issue #221 was QA-verified and merged to dev (cb58a51) and is live on palette-dev. Scope of this PR (scaled image view, no code box, raw image serving, attachment size) is covered by #224.
Pull request closed
This pull request cannot be reopened because the branch was deleted.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Verified locally: uploaded jpeg, paste view shows scaled preview and no code box, /raw returns the jpeg bytes (image/jpeg, inline); text paste regression checked. Closes #221
- paste view: image attachments render in a scalable preview (max-height min(70vh, 720px), object-fit contain) and the code box is omitted; wrap/copy buttons hidden for image pastes - SizeHuman/stats summary show the attachment size for file pastes (row.Content is empty for file pastes, was showing 0 B) - /raw/{id} on a file paste streams the attachment bytes inline with its sniffed mime and filename instead of an empty text/plain bodyState saved before VM cleanup (fen-vm storage trim). This worktree was interrupted mid-task.
Where it stands:
fix-221at1bfefe0contains a divergent approach from the pushedorigin/fix-221(98ea7ee): local version reads attachment size/line info into renderPaste (SizeBytes from blob, sizeHuman fix for attachment pastes) and addsIsImagePastetemplate var; origin version instead usesAttachmentImageflag + renders image directly in paste.html. The two implement the same #221 goal differently.fix-221-wip(1bfefe0) so nothing is lost.Nothing was deleted; all palette worktrees under /home/fen/* will be cleaned only after this state was committed upstream.
Superseded by #224 (branch fix-221, commit
98ea7ee), which was merged into dev and closed issue #221. This duplicate PR from a parallel run is closed; its branch is removed.Closing as superseded: PR #224 for the same issue #221 was QA-verified and merged to dev (
cb58a51) and is live on palette-dev. Scope of this PR (scaled image view, no code box, raw image serving, attachment size) is covered by #224.Pull request closed