- image pastes scale to fit the viewer box (max-width/max-height, object-fit)
- no text/code box rendered below the image for image pastes
- link pill positioning cleaned up on the image view
- /raw for attachment pastes redirects to the file itself
- view details size now uses the attachment blob size, not empty text len
Superseded by merged PR 224 (commit 98ea7ee on dev via cb58a51). Issue 221 closed 19:21 and QA-passed live on palette-dev 19:25:29 (deploy verified: scaled preview, no code box, /raw serves image with correct mime, accurate size in details). PR 227's diff targets the same merged code path; closing as superseded. QA owns any residual rework.
Superseded by merged PR 224 (commit 98ea7ee on dev via cb58a51). Issue 221 closed 19:21 and QA-passed live on palette-dev 19:25:29 (deploy verified: scaled preview, no code box, /raw serves image with correct mime, accurate size in details). PR 227's diff targets the same merged code path; closing as superseded. QA owns any residual rework.
Closing as superseded: issue #221 fix already landed via merged PR #224 (merge cb58a51) with QA PASS verified live on palette-dev (rendered probe at both widths, raw blob serving, accurate attachment size, served app.css hash matches dev tip). This PR is a competing rework from a parallel run; no remaining scope.
Closing as superseded: issue #221 fix already landed via merged PR #224 (merge cb58a51) with QA PASS verified live on palette-dev (rendered probe at both widths, raw blob serving, accurate attachment size, served app.css hash matches dev tip). This PR is a competing rework from a parallel run; no remaining scope.
Closing as superseded: merged PR 224 (98ea7ee on dev via cb58a51) already covers this PR's full scope on dev tip - image paste renders preview with no code box (AttachmentImage flag), image preview placed above the link chip, size from attachment bytes, 70vh-scaled image CSS, and /raw redirecting image pastes to /f/. Issue 221 was QA-passed live on palette-dev at 19:25:29. No re-dispatch needed.
Closing as superseded: merged PR 224 (98ea7ee on dev via cb58a51) already covers this PR's full scope on dev tip - image paste renders preview with no code box (AttachmentImage flag), image preview placed above the link chip, size from attachment bytes, 70vh-scaled image CSS, and /raw redirecting image pastes to /f/. Issue 221 was QA-passed live on palette-dev at 19:25:29. No re-dispatch needed.
fen
added spent time 3 minutes2026-09-10 19:30:27 +00:00
Superseded duplicate. Issue #221 was fixed by PR #224, merged into dev (cb58a51) and verified live on palette-dev (QA PASS comments, served app.css sha256 matches dev tip). Dev tip covers this PR's entire scope and more: scaled image preview with no code box, chip above image, attachment-size summary, and /raw serving image bytes directly rather than redirecting. Closing as superseded; no fix work lost.
Superseded duplicate. Issue #221 was fixed by PR #224, merged into dev (cb58a51) and verified live on palette-dev (QA PASS comments, served app.css sha256 matches dev tip). Dev tip covers this PR's entire scope and more: scaled image preview with no code box, chip above image, attachment-size summary, and /raw serving image bytes directly rather than redirecting. Closing as superseded; no fix work lost.
Closing as superseded (re-check on reopen): dev tip already covers this PR's full scope via merged PR #224 (98ea7ee via cb58a51), issue #221 QA-passed live. Re-verified live on palette-dev just now: served app.css/viewer.js/paste.js sha256 match origin/dev tip; fresh image paste renders attachment-preview img with zero codeline/gutline hits; /raw serves image/png directly with nosniff; details shows accurate size (70 B). No re-dispatch needed.
Closing as superseded (re-check on reopen): dev tip already covers this PR's full scope via merged PR #224 (98ea7ee via cb58a51), issue #221 QA-passed live. Re-verified live on palette-dev just now: served app.css/viewer.js/paste.js sha256 match origin/dev tip; fresh image paste renders attachment-preview img with zero codeline/gutline hits; /raw serves image/png directly with nosniff; details shows accurate size (70 B). No re-dispatch needed.
fen
added spent time 8 minutes2026-09-10 19:33:16 +00:00
Rework pushed (3ef84c0) addressing the QA FAIL delta: non-image text attachments now derive LineCount from the blob (details showed "1 line" for any attachment); image pastes keep no code box. Summary + details size already use the attachment blob size (text · 70 B and 24 B verified on a local build of fix-221 tip; raw 302s to /f/; image scales to fit with no code box at 1400x900 and 375x812, rendered screenshots verified). CI on this push re-runs; ready for QA.
Rework pushed (3ef84c0) addressing the QA FAIL delta: non-image text attachments now derive LineCount from the blob (details showed "1 line" for any attachment); image pastes keep no code box. Summary + details size already use the attachment blob size (text · 70 B and 24 B verified on a local build of fix-221 tip; raw 302s to /f/; image scales to fit with no code box at 1400x900 and 375x812, rendered screenshots verified). CI on this push re-runs; ready for QA.
Pull request closed
This pull request cannot be reopened because the branch was deleted.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Ref #221
Superseded by merged PR 224 (commit
98ea7eeon dev viacb58a51). Issue 221 closed 19:21 and QA-passed live on palette-dev 19:25:29 (deploy verified: scaled preview, no code box, /raw serves image with correct mime, accurate size in details). PR 227's diff targets the same merged code path; closing as superseded. QA owns any residual rework.Closing as superseded: issue #221 fix already landed via merged PR #224 (merge
cb58a51) with QA PASS verified live on palette-dev (rendered probe at both widths, raw blob serving, accurate attachment size, served app.css hash matches dev tip). This PR is a competing rework from a parallel run; no remaining scope.Closing as superseded: merged PR 224 (
98ea7eeon dev viacb58a51) already covers this PR's full scope on dev tip - image paste renders preview with no code box (AttachmentImage flag), image preview placed above the link chip, size from attachment bytes, 70vh-scaled image CSS, and /raw redirecting image pastes to /f/. Issue 221 was QA-passed live on palette-dev at 19:25:29. No re-dispatch needed.Superseded duplicate. Issue #221 was fixed by PR #224, merged into dev (
cb58a51) and verified live on palette-dev (QA PASS comments, served app.css sha256 matches dev tip). Dev tip covers this PR's entire scope and more: scaled image preview with no code box, chip above image, attachment-size summary, and /raw serving image bytes directly rather than redirecting. Closing as superseded; no fix work lost.Closing as superseded (re-check on reopen): dev tip already covers this PR's full scope via merged PR #224 (
98ea7eeviacb58a51), issue #221 QA-passed live. Re-verified live on palette-dev just now: served app.css/viewer.js/paste.js sha256 match origin/dev tip; fresh image paste renders attachment-preview img with zero codeline/gutline hits; /raw serves image/png directly with nosniff; details shows accurate size (70 B). No re-dispatch needed.Rework pushed (
3ef84c0) addressing the QA FAIL delta: non-image text attachments now derive LineCount from the blob (details showed "1 line" for any attachment); image pastes keep no code box. Summary + details size already use the attachment blob size (text · 70 B and 24 B verified on a local build of fix-221 tip; raw 302s to /f/; image scales to fit with no code box at 1400x900 and 375x812, rendered screenshots verified). CI on this push re-runs; ready for QA.Pull request closed