Owner feedback on #212: the arrow was pinned to the column right edge (absolute, right:8px), not right of the label text. This revision makes the arrow an inline element directly after the label text span (margin-left 5px), in history.html and mine.html, and drops the absolute positioning / column padding hacks in app.css.
Rendered CDP verification on a local build: gap between label text end and arrow = 5px on all 6 sortable columns at both 1400x900 and 375x812.
Fixes #209.
Owner feedback on #212: the arrow was pinned to the column right edge (absolute, right:8px), not right of the label text. This revision makes the arrow an inline element directly after the label text span (margin-left 5px), in history.html and mine.html, and drops the absolute positioning / column padding hacks in app.css.
Rendered CDP verification on a local build: gap between label text end and arrow = 5px on all 6 sortable columns at both 1400x900 and 375x812.
QA PASS (verification on closed#216): dev tip 700b825 (merge of PR #218, commit 89a9c17) is live on palette-dev.
Served /static/app.css sha256 matches git show origin/dev:internal/web/static/app.css (6838d376edcb) and contains the new inline rule (margin-left: 6px; absolute-position variant removed).
Served /history markup has all 7 sortable headers with label text before the sort-ind span, so arrows render immediately right of the label.
CI on dev tip: test + docker both success. Two rollout restarts were needed; final pod serves current assets.
Note: the initial asset hash mismatch was a stale pod, fixed by rollout restart. Issue was already closed with branch deleted; no code changes needed.
- QA PASS (verification on closed #216): dev tip 700b825 (merge of PR #218, commit 89a9c17) is live on palette-dev.
- Served /static/app.css sha256 matches git show origin/dev:internal/web/static/app.css (6838d376edcb) and contains the new inline rule (margin-left: 6px; absolute-position variant removed).
- Served /history markup has all 7 sortable headers with label text before the sort-ind span, so arrows render immediately right of the label.
- CI on dev tip: test + docker both success. Two rollout restarts were needed; final pod serves current assets.
Note: the initial asset hash mismatch was a stale pod, fixed by rollout restart. Issue was already closed with branch deleted; no code changes needed.
fen
added spent time 12 minutes2026-09-10 18:27:47 +00:00
fen
added spent time 13 minutes2026-09-10 18:28:00 +00:00
QA verified against the superseding fix (PR #218, merged to dev as 89a9c17). Superseded PR #216 head f100c490 is not on dev and its target work is served live: app.css sha256 matches origin/dev tip, and rendered CDP probe on /mine (viewer cookie) shows the sort arrow 6px right of label text on all 6 sortable columns at 1400x900 and 375x812. Issue lifecycle complete; no further action.
QA verified against the superseding fix (PR #218, merged to dev as 89a9c17). Superseded PR #216 head f100c490 is not on dev and its target work is served live: app.css sha256 matches origin/dev tip, and rendered CDP probe on /mine (viewer cookie) shows the sort arrow 6px right of label text on all 6 sortable columns at 1400x900 and 375x812. Issue lifecycle complete; no further action.
Pull request closed
This pull request cannot be reopened because the branch was deleted.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Fixes #209.
Owner feedback on #212: the arrow was pinned to the column right edge (absolute, right:8px), not right of the label text. This revision makes the arrow an inline element directly after the label text span (margin-left 5px), in history.html and mine.html, and drops the absolute positioning / column padding hacks in app.css.
Rendered CDP verification on a local build: gap between label text end and arrow = 5px on all 6 sortable columns at both 1400x900 and 375x812.
700b825(merge of PR #218, commit89a9c17) is live on palette-dev.Note: the initial asset hash mismatch was a stale pod, fixed by rollout restart. Issue was already closed with branch deleted; no code changes needed.
QA verified against the superseding fix (PR #218, merged to dev as
89a9c17). Superseded PR #216 headf100c490is not on dev and its target work is served live: app.css sha256 matches origin/dev tip, and rendered CDP probe on /mine (viewer cookie) shows the sort arrow 6px right of label text on all 6 sortable columns at 1400x900 and 375x812. Issue lifecycle complete; no further action.Pull request closed